tustvold commented on code in PR #4326:
URL: https://github.com/apache/arrow-rs/pull/4326#discussion_r1213073769
##########
parquet/src/column/reader.rs:
##########
@@ -533,12 +542,7 @@ where
if self.num_buffered_values == 0
|| self.num_buffered_values == self.num_decoded_values
{
- // TODO: should we return false if read_new_page() = true and
- // num_buffered_values = 0?
- match self.page_reader.peek_next_page()? {
- Some(next_page) => Ok(next_page.num_rows != 0),
- None => Ok(false),
- }
+ Ok(self.page_reader.peek_next_page()?.is_some())
Review Comment:
This makes the behaviour more consistent, it will return true if there is a
page remaining, regardless of its contents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
