aprimadi commented on code in PR #6525:
URL: https://github.com/apache/arrow-datafusion/pull/6525#discussion_r1214267103


##########
datafusion/optimizer/src/decorrelate_predicate_subquery.rs:
##########
@@ -155,6 +152,17 @@ impl OptimizerRule for DecorrelatePredicateSubquery {
             _ => Ok(None),
         }
     }
+}
+
+impl OptimizerRule for DecorrelatePredicateSubquery {
+    fn try_optimize(

Review Comment:
   cc @jackwener @alamb
   
   Is this looking ok? The problem I'm encountering is that every queries 
optimization use the same shared AliasGenerator. Thus, the `alias ID` is ever 
increasing. Instead, I think it should be instantiated per query, which is what 
this code does.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to