LouisGariepy opened a new issue, #6537: URL: https://github.com/apache/arrow-datafusion/issues/6537
This is part of the ongoing effort of cleaning the remaining clippy allows after #207. [Here's](https://github.com/LouisGariepy/arrow-datafusion/blob/20c5ebdcb2e6fa9edbbe5e0ea22f33f3d47e64eb/datafusion/core/src/avro_to_arrow/reader.rs#L158-L165) the problematic source. The problem is that `avro_to_arrow::reader::Reader` implements both an inherent `next` method *and* the `Iterator` trait. This can create confusion and is unidiomatic w.r.t. to using standard traits where possible. [A potential solution](https://github.com/apache/arrow-datafusion/pull/6464#discussion_r1209221136) is to rework `AvroArrowArrayReader::next_batch` so it returns an `Option<ArrowResult<RecordBatch>>` instead of a `ArrowResult<Option<RecordBatch>>`. This makes it possible to remove the `avro_to_arrow::reader::Reader::next` method entirely and move its body into the `Iterator` implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
