davisusanibar commented on code in PR #35570:
URL: https://github.com/apache/arrow/pull/35570#discussion_r1218750254
##########
java/dataset/src/main/java/org/apache/arrow/dataset/substrait/AceroSubstraitConsumer.java:
##########
@@ -90,6 +91,15 @@ public ArrowReader runQuery(ByteBuffer plan, Map<String,
ArrowReader> namedTable
return execute(plan, namedTables);
}
+ public List<String> runDeserializeExpressions(ByteBuffer plan) {
Review Comment:
Deleted
##########
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanOptions.java:
##########
@@ -56,10 +58,26 @@ public ScanOptions(long batchSize, Optional<String[]>
columns) {
Preconditions.checkNotNull(columns);
this.batchSize = batchSize;
this.columns = columns;
+ this.projectExpression = Optional.empty();
+ }
+
+ /**
+ * Constructor.
+ * @param batchSize Maximum row number of each returned {@link
org.apache.arrow.vector.ipc.message.ArrowRecordBatch}
+ * @param columns (Optional) Projected columns. {@link Optional#empty()} for
scanning all columns. Otherwise,
+ * Only columns present in the Array will be scanned.
+ * @param projectExpression (Optional) Expressions to evaluate to produce
columns
+ */
+ public ScanOptions(long batchSize, Optional<String[]> columns,
Optional<ByteBuffer> projectExpression) {
Review Comment:
Added builder class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
