alamb opened a new pull request, #6587: URL: https://github.com/apache/arrow-datafusion/pull/6587
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Part of https://github.com/apache/arrow-datafusion/issues/1754 (see https://github.com/apache/arrow-datafusion/issues/1754#issuecomment-1579410979) # Rationale for this change I am trying to extract `physical_plan` into its own crate to improve modularity and compile times -- FromSlice is currently defined in the core crate and used in physical_plan I am also trying to make sure the organization of the DataFusion crate is easier to understand for beginners (to make it easier to start) # What changes are included in this PR? Remove the DataFusion specific `FromSlice` trait in favor of the arrow `From` impl # Are these changes tested? Covered by existing tests # Are there any user-facing changes? `from_slice` is no longer available (users should use the `From` impl in arrow-rs instead) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
