mapleFU commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1224304101


##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -219,6 +219,7 @@ class FileReaderImpl : public FileReader {
     ctx->iterator_factory = SomeRowGroupsFactory(row_groups);
     ctx->filter_leaves = true;
     ctx->included_leaves = included_leaves;
+    ctx->use_large_binary_variants = 
reader_properties_.use_large_binary_variants();

Review Comment:
   @arthurpassos Yes, that is what I mean in 
https://github.com/apache/arrow/pull/35825#pullrequestreview-1471347718
   
   But this comment is just that, you've add logic in `GetColumnReader`, should 
same logic be applied in `GetReader`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to