alamb opened a new pull request, #6619: URL: https://github.com/apache/arrow-datafusion/pull/6619
# Which issue does this PR close? This is related to #5781 # Rationale for this change I would like to ensure that user defined window functions have the same expressive power as built in window functions. In order to achieve this goal, all the important information about a window function is provided by a trait (rather than by other code special casing based on the type). # What changes are included in this PR? 1. Move `get_equal_orderings` into `BuiltInWindowFunctionExpr` 2. Remove `BuiltInWindowFunctionExpr::as_any` (which is how I found the special case for RowNumber) # Are these changes tested? Covered by existing tests <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> # Are there any user-facing changes? No this only changes internal APIs Note that my proposal in https://github.com/apache/arrow-datafusion/pull/6617 for user defined window functions is to make `BuiltInWindowFunctionExpr` public. However, even if we choose another option, I think this still PR makes the code more explicit and easier to find functionality related to window functions so I think it is still a good change <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
