WillAyd commented on code in PR #758:
URL: https://github.com/apache/arrow-adbc/pull/758#discussion_r1224943477
##########
c/driver/postgresql/postgres_copy_reader.h:
##########
@@ -635,6 +635,19 @@ static inline ArrowErrorCode MakeCopyFieldReader(const
PostgresType& pg_type,
default:
return ErrorCantConvert(error, pg_type, schema_view);
}
+
+ case NANOARROW_TYPE_TIMESTAMP:
+ switch (pg_type.type_id()) {
+ case PostgresTypeId::kTimestamp: {
+ // 2000-01-01 00:00:00.000000 in microseconds
Review Comment:
Huh that's interesting. Strange that client queries don't work that way:
```psql
postgres=# SELECT 'epoch'::timestamp;
timestamp
---------------------
1970-01-01 00:00:00
(1 row)
```
Something to watch out for in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
