adamreeve commented on code in PR #35920:
URL: https://github.com/apache/arrow/pull/35920#discussion_r1225222340
##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/ArrowStreamWriter.java:
##########
@@ -121,4 +129,45 @@ public static void writeEndOfStream(WriteChannel out,
IpcOption option) throws I
protected void endInternal(WriteChannel out) throws IOException {
writeEndOfStream(out, option);
}
+
+ @Override
+ protected void ensureDictionariesWritten(DictionaryProvider provider,
Set<Long> dictionaryIdsUsed)
Review Comment:
Yeah I don't think there's a way to avoid this due to needing to account for
mutable vectors, I've added a comment about this in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
