returnString commented on a change in pull request #8917:
URL: https://github.com/apache/arrow/pull/8917#discussion_r543706456
##########
File path: rust/datafusion/src/datasource/parquet.rs
##########
@@ -65,6 +66,7 @@ impl TableProvider for ParquetTable {
&self,
projection: &Option<Vec<usize>>,
batch_size: usize,
+ _filters: &[Expr],
Review comment:
@yordan-pavlov Likewise!
Are you broadly happy that this interface and implementation would suffice
for your Parquet-specific work? My use case is an entirely external
TableProvider implementation, so hopefully that's kept my assumptions to a
minimum.
If you've got time, seeing as you've been working in this area, I'd really
appreciate any other thoughts you might have here :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
