[GitHub] [arrow] zeroshade commented on a diff in pull request #35999: MINOR: [Go] use `Decimal256Type` in `TestSwapEndianPrimitiveArrayData`

[via GitHub]

zeroshade commented on code in PR #35999:
URL: https://github.com/apache/arrow/pull/35999#discussion_r1226804437


##########
go/arrow/ipc/endian_swap_test.go:
##########
@@ -56,6 +56,7 @@ func TestSwapEndianPrimitiveArrayData(t *testing.T) {
                {arrow.PrimitiveTypes.Int32, 2, "01234567", "32107654"},
                {arrow.PrimitiveTypes.Uint64, 1, "01234567", "76543210"},
                {&arrow.Decimal128Type{Precision: 38, Scale: 10}, 1, 
"0123456789abcdef", "fedcba9876543210"},
+               {&arrow.Decimal256Type{Precision: 72, Scale: 10}, 0, 
"0123456789abcdef", "fedcba9876543210"},

Review Comment:
   Also, the data should be 32-bytes for Decimal256, not 16



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org