lidavidm commented on code in PR #783:
URL: https://github.com/apache/arrow-adbc/pull/783#discussion_r1228641705
##########
c/driver/common/CMakeLists.txt:
##########
@@ -17,8 +17,8 @@
add_library(adbc_driver_common STATIC utils.c)
set_target_properties(adbc_driver_common PROPERTIES POSITION_INDEPENDENT_CODE
ON)
-include_directories(SYSTEM ${REPOSITORY_ROOT})
-include_directories(SYSTEM ${REPOSITORY_ROOT}/c/vendor)
+target_include_directories(adbc_driver_common SYSTEM
Review Comment:
But for nanoarrow I wanted the SYSTEM flag for precisely that reason (that
said, we could probably also include nanoarrow as non-system)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
