zeroshade commented on code in PR #36163:
URL: https://github.com/apache/arrow/pull/36163#discussion_r1235490902
##########
go/parquet/pqarrow/file_writer.go:
##########
@@ -134,13 +134,19 @@ func (fw *FileWriter) RowGroupTotalBytesWritten() int64 {
return 0
}
-// WriteBuffered allows to write records and decide where to break your row
group
-// based on the TotalBytesWritten rather than on the max row group len.
-// If using Records, this should be paired with NewBufferedRowGroup,
-// while Write will always write a new record as a row group in and of itself.
+// WriteBuffered will either append to an existing row group or create a new
one
+// based on the record length and RowGroupTotalBytesWritten.
Review Comment:
`WriteBuffered` itself never checks `RowGroupTotalBytesWritten`, unless i'm
missing something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
