danepitkin commented on code in PR #36130:
URL: https://github.com/apache/arrow/pull/36130#discussion_r1235952089


##########
python/pyarrow/table.pxi:
##########
@@ -1787,6 +1941,35 @@ cdef class _Tabular(_PandasConvertible):
         """
         return _pc().take(self, indices)
 
+    def to_pydict(self):
+        raise NotImplementedError

Review Comment:
   I ran the following code in IPython and received the results below. No 
performance difference found in my basic testing.
   
   ```
   import random
   import string
   import pyarrow as pa
   
   arr0 = [random.randint(0, 2_000_000) for _ in range(1_000_000)]
   arr1 = [''.join(random.choices(string.ascii_uppercase + string.digits, 
k=10)) for _ in range(1_000_000)]
   table = pa.table([arr0, arr1], ["c0", "c1"])
   ```
   ```%timeit table.to_pydict()```
   
   Before
   `2.03 s ± 7.6 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)`
   After
   `1.99 s ± 7.99 ms per loop (mean ± std. dev. of 7 runs, 1 loop each)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to