rdettai commented on a change in pull request #8917:
URL: https://github.com/apache/arrow/pull/8917#discussion_r545240967
##########
File path: rust/datafusion/src/datasource/datasource.rs
##########
@@ -34,6 +35,23 @@ pub struct Statistics {
pub total_byte_size: Option<usize>,
}
+/// Indicates whether and how a filter expression can be handled by a
+/// TableProvider for table scans.
+#[derive(Debug, Clone)]
+pub enum TableProviderFilterPushDown {
+ /// The expression cannot be used by the provider.
+ Unsupported,
+ /// The expression can be used to help minimise the data retrieved,
+ /// but the provider cannot guarantee that all returned tuples
Review comment:
I see... that's annoying! how many tests fail approximately?
If tests influence our design, we should be sure that they are doing so for
a reason (not just because they are poorly written). Here I feel that maybe we
should fix them, no? In #8910, I already tweaked an API because otherwise I
would have had lots of tests to change (more details
[here](https://github.com/apache/arrow/pull/8910#discussion_r543331995)). This
was a mistake (due mainly to laziness 🙃), but here I believe the interface is
too important to do the same 😄. Any opinion @alamb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
