pitrou commented on code in PR #36215: URL: https://github.com/apache/arrow/pull/36215#discussion_r1238300029
########## cpp/src/arrow/c/helpers.h: ########## @@ -18,10 +18,20 @@ #pragma once #include <assert.h> +#include <stdio.h> +#include <stdlib.h> #include <string.h> #include "arrow/c/abi.h" +#define CHECK_OR_DIE(condition, msg) \ Review Comment: We need to namespace-prefix this macro to avoid clashes with third-party libs. Perhaps name it `ARROW_C_ASSERT`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
