pitrou commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1238512712
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -488,14 +490,15 @@ void DoRoundTripWithBatches(
ASSERT_OK_AND_ASSIGN(*out, Table::FromRecordBatchReader(batch_reader.get()));
}
-void CheckSimpleRoundtrip(
- const std::shared_ptr<Table>& table, int64_t row_group_size,
- const std::shared_ptr<ArrowWriterProperties>& arrow_writer_properties =
- default_arrow_writer_properties()) {
+void CheckSimpleRoundtrip(const std::shared_ptr<Table>& table, int64_t
row_group_size,
+ const std::shared_ptr<ArrowWriterProperties>&
+ arrow_writer_properties =
default_arrow_writer_properties(),
+ const ArrowReaderProperties& arrow_reader_properties
=
+ default_arrow_reader_properties()) {
Review Comment:
Same here: the new argument is getting passed to a function that doesn't use
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
