pitrou commented on code in PR #36067:
URL: https://github.com/apache/arrow/pull/36067#discussion_r1238642308
##########
cpp/src/arrow/compute/kernels/scalar_set_lookup_benchmark.cc:
##########
@@ -56,8 +56,8 @@ static void SetLookupBenchmarkString(benchmark::State& state,
template <typename Type>
static void SetLookupBenchmarkNumeric(benchmark::State& state,
const std::string& func_name,
- const int64_t value_set_length) {
- const int64_t array_length = 1 << 18;
+ const int64_t value_set_length,
+ const int64_t array_length) {
Review Comment:
perhaps add `state.counters["value_set_length"] = value_set_length`
somewhere below to make results more readable? (same in the other bench
function)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
