arthurpassos commented on code in PR #35825: URL: https://github.com/apache/arrow/pull/35825#discussion_r1242217123
########## cpp/src/parquet/encoding.cc: ########## @@ -3200,6 +3311,9 @@ class DeltaByteArrayDecoder : public DecoderImpl, std::shared_ptr<ResizableBuffer> buffered_data_; }; +using DeltaByteArrayDecoder = DeltaByteArrayDecoderBase<ByteArrayType>; +using DeltaLargeByteArrayDecoder = DeltaByteArrayDecoderBase<LargeByteArrayType>; Review Comment: I have added a test that validates a regular ByteArray (read non large) can be read even with `use_large_binary_variants`. Is that the test you want? Or you want a test that validates an overflow string can be read using this encoding? If so, is it actually possible? I might be wrong, but I do recall a previous conversation where it was established it will fallback plain encoding due to the string size -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
