mapleFU commented on code in PR #36298:
URL: https://github.com/apache/arrow/pull/36298#discussion_r1242299592
##########
cpp/src/parquet/encoding_benchmark.cc:
##########
@@ -102,6 +102,18 @@ static void BM_PlainEncodingInt64(benchmark::State& state)
{
BENCHMARK(BM_PlainEncodingInt64)->Range(MIN_RANGE, MAX_RANGE);
+static void BM_DictEncodingInt64(benchmark::State& state) {
+ std::vector<int64_t> values(state.range(0), 64);
Review Comment:
I can retry to list more num-distinct-value and testing it here.
##########
cpp/src/parquet/encoding_benchmark.cc:
##########
@@ -102,6 +102,18 @@ static void BM_PlainEncodingInt64(benchmark::State& state)
{
BENCHMARK(BM_PlainEncodingInt64)->Range(MIN_RANGE, MAX_RANGE);
+static void BM_DictEncodingInt64(benchmark::State& state) {
+ std::vector<int64_t> values(state.range(0), 64);
Review Comment:
I can try to list more num-distinct-value and testing it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
