wgtmac commented on code in PR #35825: URL: https://github.com/apache/arrow/pull/35825#discussion_r1242423439
########## cpp/src/parquet/encoding.cc: ########## @@ -3200,6 +3311,9 @@ class DeltaByteArrayDecoder : public DecoderImpl, std::shared_ptr<ResizableBuffer> buffered_data_; }; +using DeltaByteArrayDecoder = DeltaByteArrayDecoderBase<ByteArrayType>; +using DeltaLargeByteArrayDecoder = DeltaByteArrayDecoderBase<LargeByteArrayType>; Review Comment: Thanks for adding the test! I do see that you have extended `TEST(TestArrowReadDeltaEncoding, DeltaByteArray)` to read into large binary. Could you also add a similar one for `TEST(TestArrowReadDeltaEncoding, DeltaBinaryPacked)`? I don't think the overflow case is needed. Just want to make sure all four binary-encodings are covered. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
