lidavidm commented on code in PR #861:
URL: https://github.com/apache/arrow-adbc/pull/861#discussion_r1245548625
##########
c/validation/adbc_validation_util.cc:
##########
@@ -141,7 +141,16 @@ int MakeSchema(struct ArrowSchema* schema, const
std::vector<SchemaField>& field
CHECK_ERRNO(ArrowSchemaSetTypeStruct(schema, fields.size()));
size_t i = 0;
for (const SchemaField& field : fields) {
- CHECK_ERRNO(ArrowSchemaSetType(schema->children[i], field.type));
+ switch (field.type) {
+ case NANOARROW_TYPE_TIMESTAMP:
+ // TODO: don't hardcode unit here
+ CHECK_ERRNO(ArrowSchemaSetTypeDateTime(schema->children[i], field.type,
+ NANOARROW_TIME_UNIT_MICRO,
Review Comment:
I think this is OK for now but I think what I might end up doing is writing
up a set of Googletest matchers so we can write out code like
```cpp
ASSERT_THAT(view->children[0], IsTimestamp(/*any unit*/));
ASSERT_THAT(view->children[0], IsTimestamp(NANOARROW_TIME_UNIT_MICRO));
```
or something like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
