kou commented on code in PR #36373:
URL: https://github.com/apache/arrow/pull/36373#discussion_r1246647006
##########
.github/workflows/js.yml:
##########
@@ -90,6 +90,14 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
+ - name: Jest Cache
+ uses: actions/cache@v3
+ with:
+ path: js/.jest-cache
+ key: js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('js/yarn.lock') }}
+ restore-keys: |
+ js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-
+ js-jest-cache-${{ runner.os }}-
Review Comment:
Do we need this?
(Can we reuse cache for different Node.js version?)
##########
.github/workflows/js.yml:
##########
@@ -90,6 +90,14 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
+ - name: Jest Cache
+ uses: actions/cache@v3
+ with:
+ path: js/.jest-cache
+ key: js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('js/yarn.lock') }}
Review Comment:
```suggestion
key: js-jest-cache-${{ runner.os }}-${{ matrix.node }}-${{
hashFiles('js/yarn.lock') }}
```
##########
.github/workflows/js.yml:
##########
@@ -90,6 +90,14 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
+ - name: Jest Cache
+ uses: actions/cache@v3
+ with:
+ path: js/.jest-cache
+ key: js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('js/yarn.lock') }}
+ restore-keys: |
+ js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-
Review Comment:
```suggestion
js-jest-cache-${{ runner.os }}-${{ matrix.node }}-
```
##########
.github/workflows/js.yml:
##########
@@ -114,6 +122,14 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
+ - name: Jest Cache
+ uses: actions/cache@v3
+ with:
+ path: js/.jest-cache
+ key: js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-${{
hashFiles('js/yarn.lock') }}
+ restore-keys: |
+ js-jest-cache-${{ runner.os }}-${{ matrix.node-version }}-
Review Comment:
```suggestion
key: js-jest-cache-${{ runner.os }}-${{ matrix.node }}-${{
hashFiles('js/yarn.lock') }}
restore-keys: |
js-jest-cache-${{ runner.os }}-${{ matrix.node }}-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
