westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r546031132
##########
File path: cpp/src/arrow/util/future_test.cc
##########
@@ -122,15 +122,21 @@ void AssertFinished(const Future<T>& fut) {
// Assert the future is successful *now*
template <typename T>
void AssertSuccessful(const Future<T>& fut) {
- ASSERT_EQ(fut.state(), FutureState::SUCCESS);
- ASSERT_OK(fut.status());
+ ASSERT_TRUE(fut.Wait(0.1));
Review comment:
Yes, that is write, `status` was the blocking call. You are also right
that it was not succeeding. However, it would hang indefinitely. This made it
more difficult to debug.
So the old implementation was correct, but inconvenient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
