mapleFU commented on code in PR #35453:
URL: https://github.com/apache/arrow/pull/35453#discussion_r1249246627


##########
python/pyarrow/_parquet.pyx:
##########
@@ -1665,6 +1919,82 @@ cdef shared_ptr[ArrowWriterProperties] 
_create_arrow_writer_properties(
 
     return arrow_properties
 
+cdef _name_to_index_map(Schema arrow_schema):
+    cdef:
+        shared_ptr[CSchema] sp_arrow_schema
+        shared_ptr[SchemaDescriptor] sp_parquet_schema
+        shared_ptr[WriterProperties] props = _create_writer_properties()
+        shared_ptr[ArrowWriterProperties] arrow_props = 
_create_arrow_writer_properties(
+            use_deprecated_int96_timestamps=False,
+            coerce_timestamps=None,
+            allow_truncated_timestamps=False,
+            writer_engine_version="V2"
+        )
+
+    sp_arrow_schema = pyarrow_unwrap_schema(arrow_schema)

Review Comment:
   so a nested path could be like `a.b.c`?



##########
python/pyarrow/_parquet.pyx:
##########
@@ -1665,6 +1919,82 @@ cdef shared_ptr[ArrowWriterProperties] 
_create_arrow_writer_properties(
 
     return arrow_properties
 
+cdef _name_to_index_map(Schema arrow_schema):
+    cdef:
+        shared_ptr[CSchema] sp_arrow_schema
+        shared_ptr[SchemaDescriptor] sp_parquet_schema
+        shared_ptr[WriterProperties] props = _create_writer_properties()
+        shared_ptr[ArrowWriterProperties] arrow_props = 
_create_arrow_writer_properties(
+            use_deprecated_int96_timestamps=False,

Review Comment:
   Is these default schema? or these doesn't matter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to