thisisnic commented on PR #36374:
URL: https://github.com/apache/arrow/pull/36374#issuecomment-1621327596
Sorry for the delay on this, have been on holiday.
> I am wondering if r/pkgdown/templates/navbar.html is also not currently in
use and could be removed. (which seems to have nothing to do with fixing this
issue)
Unsure without looking into this if it's a custom template or not, but open
to removing it if it's not used - let's discuss in another issue.
Not a criticism but an FYI - I would have approved this sooner with a bit
more information confirming that we no longer use the tabset functionality that
is implemented in `extra.js`, but I had a scan through the code and it appears
we no longer use this, so it looks good to remove it.
Thanks for investigating and fixing this @eitsupi, it'll be helpful to have
the search functionality working now!
Before I merge this, would you mind removing `{.tabset}` on line 90 in
`vignettes/developers/setup.Rmd`? If you don't get to it before I get back,
I'll push the change to the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
