tustvold commented on code in PR #4478:
URL: https://github.com/apache/arrow-rs/pull/4478#discussion_r1254341418
##########
parquet/src/arrow/async_writer/mod.rs:
##########
@@ -128,7 +137,7 @@ impl<W: AsyncWrite + Unpin + Send> AsyncArrowWriter<W> {
let metadata = self.sync_writer.close()?;
// Force to flush the remaining data.
- Self::try_flush(&mut self.shared_buffer, &mut self.async_writer,
true).await?;
+ Self::try_flush(&mut self.shared_buffer, &mut self.async_writer, 0,
true).await?;
Review Comment:
Perhaps we could now remove the force argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
