pitrou commented on PR #35810: URL: https://github.com/apache/arrow/pull/35810#issuecomment-1623913169
I will say again that I think the callbacks should be `Cdecl`, not `Stdcall`. `Stdcall` is the calling convention for WinAPI functions and nothing else, AFAICT. `Cdecl` is the default calling convention for any other C/C++ code, such as the callbacks that producers will pass in the `release` member. See: https://www.codeproject.com/Articles/1388/Calling-Conventions-Demystified -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
