westonpace commented on code in PR #36539:
URL: https://github.com/apache/arrow/pull/36539#discussion_r1256149068
##########
python/pyarrow/tests/test_table.py:
##########
@@ -2422,3 +2422,27 @@ def test_numpy_asarray(constructor):
result = np.asarray(table3, dtype="int32")
np.testing.assert_allclose(result, expected)
assert result.dtype == "int32"
+
+
+def test_invalid_non_join_column():
+ NUM_ITEMS = 30
+ t1 = pa.Table.from_pydict({
+ 'id': [x.to_bytes(4, 'big') for x in range(NUM_ITEMS)],
Review Comment:
```suggestion
'id': range(NUM_ITEMS),
```
Any particular reason to used byte strings here? It seems to add complexity
to the test.
##########
python/pyarrow/tests/test_table.py:
##########
@@ -2422,3 +2422,27 @@ def test_numpy_asarray(constructor):
result = np.asarray(table3, dtype="int32")
np.testing.assert_allclose(result, expected)
assert result.dtype == "int32"
+
+
+def test_invalid_non_join_column():
+ NUM_ITEMS = 30
+ t1 = pa.Table.from_pydict({
+ 'id': [x.to_bytes(4, 'big') for x in range(NUM_ITEMS)],
+ 'array_column': [[z for z in range(3)] for x in range(NUM_ITEMS)],
+ })
+ t2 = pa.Table.from_pydict({
+ 'id': [x.to_bytes(4, 'big') for x in range(NUM_ITEMS)],
Review Comment:
```suggestion
'id': range(NUM_ITEMS),
```
Same comment as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
