jayzhan211 commented on code in PR #6872: URL: https://github.com/apache/arrow-datafusion/pull/6872#discussion_r1256648051
########## datafusion/core/tests/sqllogictests/test_files/array.slt: ########## @@ -365,6 +365,31 @@ select array_concat(make_array(), make_array(2, 3)); ---- [2, 3] +# array_concat with different dimensions +# 2D + 1D +query ? +select array_concat(make_array([1,2], [3,4]), make_array(5, 6)) +---- +[[1, 2], [3, 4], [5, 6]] + +# 1D + 2D +query ? +select array_concat(make_array(5, 6), make_array([1,2], [3,4])) +---- +[[5, 6], [1, 2], [3, 4]] + +# 2D + 1D + 1D +query ? +select array_concat(make_array([1,2], [3,4]), make_array(5, 6), make_array(7,8)) +---- +[[1, 2], [3, 4], [5, 6], [7, 8]] + +# 1D + 2D + 3D +query ? +select array_concat(make_array(10, 20), make_array([30, 40]), make_array([[50, 60]])) +---- +[[[10, 20]], [[30, 40]], [[50, 60]]] + Review Comment: This PR fails on the concatenation operator. I will request another PR on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
