mapleFU commented on PR #36510:
URL: https://github.com/apache/arrow/pull/36510#issuecomment-1627576815

   Personally I think create column chunk with a buffer size is tricky. And 
maybe something like:
   
   ```
   class ColumnReaderProperties {
      void set_buffer_size(int64_t);
      int64_t buffer_size();
   };
   
   class ReaderProperties {
      // default?
      int64_t buffer_size();
      // 
      int64_t buffer_size(int column_id);
   
   private:
     int64_t default_buffer_size_;
     // col -> 
     std::map<int, ColumnReaderProperties> column_properties_;
   };
   ```
   
   would this make code better for this?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to