alamb commented on code in PR #6891:
URL: https://github.com/apache/arrow-datafusion/pull/6891#discussion_r1257494785
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -1005,6 +1005,7 @@ macro_rules! binary_array_op_dyn_scalar {
ScalarValue::LargeUtf8(v) => compute_utf8_op_dyn_scalar!($LEFT, v,
$OP, $OP_TYPE),
ScalarValue::Binary(v) => compute_binary_op_dyn_scalar!($LEFT, v,
$OP, $OP_TYPE),
ScalarValue::LargeBinary(v) =>
compute_binary_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE),
+ ScalarValue::FixedSizeBinary(_, v) =>
compute_binary_op_dyn_scalar!($LEFT, v, $OP, $OP_TYPE),
Review Comment:
I think this is the only actual code change
I wrote some tests for it here:
https://github.com/apache/arrow-datafusion/pull/6895
##########
Cargo.toml:
##########
@@ -35,7 +35,7 @@ members = [
]
[workspace.package]
-version = "26.0.0"
+version = "27.0.0"
Review Comment:
It is strange the diff shows these changes as they seem to have been made on
master 🤔
##########
Cargo.toml:
##########
@@ -35,7 +35,7 @@ members = [
]
[workspace.package]
-version = "26.0.0"
+version = "27.0.0"
Review Comment:
It is strange the diff shows these changes as they seem to have been made on
master 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
