assignUser commented on code in PR #36581:
URL: https://github.com/apache/arrow/pull/36581#discussion_r1257652834
##########
cpp/cmake_modules/FindgRPCAlt.cmake:
##########
@@ -45,6 +47,7 @@ if(GRPCPP_PC_FOUND)
HINTS ${GRPCPP_PC_STATIC_LIBRARY_DIRS})
list(APPEND GRPCPP_LINK_LIBRARIES
"${GRPCPP_LIBRARY_${GRPCPP_LIBRARY_NAME}}")
endforeach()
+ list(APPEND GRPCPP_LINK_LIBRARIES Threads::Threads)
Review Comment:
This is duplicated from L39, should we move it under the if as it is
appended to the list in all cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
