kou commented on code in PR #36595:
URL: https://github.com/apache/arrow/pull/36595#discussion_r1258397046
##########
.github/workflows/cpp.yml:
##########
@@ -301,15 +299,15 @@ jobs:
uses: actions/cache@v3
with:
path: ${{ steps.ccache-info.outputs.cache-dir }}
- key: cpp-ccache-windows-${{ env.CACHE_VERSION }}-${{
hashFiles('cpp/**') }}
- restore-keys: cpp-ccache-windows-${{ env.CACHE_VERSION }}-
+ key: cpp-ccache-windows-${{ matrix.version }}-${{ env.CACHE_VERSION
}}-${{ hashFiles('cpp/**') }}
+ restore-keys: cpp-ccache-windows-${{ matrix.version }}-${{
env.CACHE_VERSION }}-
env:
# We can invalidate the current cache by updating this.
CACHE_VERSION: "2022-09-13"
- name: Build
shell: cmd
run: |
- call "C:\Program Files (x86)\Microsoft Visual
Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
+ call "C:\Program Files (x86)\Microsoft Visual
Studio\*\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
Review Comment:
```suggestion
call "C:\Program Files (x86)\Microsoft Visual Studio\${{
matrix.version }}\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
