alamb commented on code in PR #6915:
URL: https://github.com/apache/arrow-datafusion/pull/6915#discussion_r1259965878
##########
datafusion/core/tests/user_defined/user_defined_window_functions.rs:
##########
@@ -365,6 +398,8 @@ struct TestState {
supports_bounded_execution: bool,
/// should the functions they need include rank
include_rank: bool,
+ /// should the functions return NULL for 0s?
Review Comment:
❤️
##########
datafusion/core/tests/user_defined/user_defined_window_functions.rs:
##########
@@ -365,6 +398,8 @@ struct TestState {
supports_bounded_execution: bool,
/// should the functions they need include rank
include_rank: bool,
+ /// should the functions return NULL for 0s?
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
