paleolimbot commented on code in PR #255:
URL: https://github.com/apache/arrow-nanoarrow/pull/255#discussion_r1261123412
##########
docs/source/getting-started.md:
##########
@@ -364,7 +364,7 @@ static int linesplitter_read_internal(const std::string&
src, ArrowArray* out,
src_view.size_bytes -= next_newline + 1;
}
- NANOARROW_RETURN_NOT_OK(ArrowArrayFinishBuildingDefault(tmp.get(), error));
+ NANOARROW_RETURN_NOT_OK(ArrowArrayFinishBuilding(tmp.get(), error));
Review Comment:
This one should definitely be `ArrowArrayFinishBuildingDefault()` (although
this changed between 0.1 and 0.2, so perhaps there's a reference to 0.1 above
that needs fixing?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
