omixen commented on code in PR #36646:
URL: https://github.com/apache/arrow/pull/36646#discussion_r1261481618
##########
go/parquet/file/file_writer.go:
##########
@@ -165,7 +166,9 @@ func (fw *Writer) Close() error {
fw.rowGroupWriter.Close()
}
fw.rowGroupWriter = nil
- defer fw.sink.Close()
+ defer func() {
+ err = errors.Join(err, fw.sink.Close())
Review Comment:
unless.. I can't use `errors.Join` (go 1.20), since I see the build fails on
a few machines, can I upgrade the go version in the go git workflow as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
