WillAyd commented on code in PR #901:
URL: https://github.com/apache/arrow-adbc/pull/901#discussion_r1261698874
##########
c/driver/sqlite/sqlite_test.cc:
##########
@@ -189,12 +189,13 @@ class SqliteStatementTest : public ::testing::Test,
void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpTest()); }
void TearDown() override { ASSERT_NO_FATAL_FAILURE(TearDownTest()); }
- void TestSqlIngestUInt64() { GTEST_SKIP() << "Cannot ingest UINT64 (out of
range)"; }
- void TestSqlIngestBinary() { GTEST_SKIP() << "Cannot ingest BINARY (not
implemented)"; }
- void TestSqlIngestTimestampTz() {
Review Comment:
All of the sqlite datetime functions use UTC internally, so I think
reasonable to just let the implementation discard the tz
https://www.sqlite.org/lang_datefunc.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
