kou commented on code in PR #36434:
URL: https://github.com/apache/arrow/pull/36434#discussion_r1263231485
##########
cpp/src/arrow/util/value_parsing.h:
##########
@@ -40,6 +40,8 @@
namespace arrow {
+#define FASTFLOAT_ALLOWS_LEADING_PLUS 1
+
Review Comment:
Can we move this to `.cc` (`cpp/src/arrow/util/value_parsing.cc`)?
I think that we don't need to export this to other files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]