tustvold commented on code in PR #4513:
URL: https://github.com/apache/arrow-rs/pull/4513#discussion_r1263943313
##########
arrow-cast/src/cast.rs:
##########
@@ -7874,13 +7471,13 @@ mod tests {
assert_eq!(946728000000, c.value(0));
assert!(c.is_valid(1)); // "2020-12-15T12:34:56"
assert_eq!(1608035696000, c.value(1));
- assert!(c.is_valid(2)); // "2020-2-2T12:34:56"
- assert_eq!(1580646896000, c.value(2));
+ assert!(!c.is_valid(2)); // "2020-2-2T12:34:56"
Review Comment:
Yeah, it is also not correct according to RFC3339
##########
arrow-cast/src/cast.rs:
##########
@@ -7874,13 +7471,13 @@ mod tests {
assert_eq!(946728000000, c.value(0));
assert!(c.is_valid(1)); // "2020-12-15T12:34:56"
assert_eq!(1608035696000, c.value(1));
- assert!(c.is_valid(2)); // "2020-2-2T12:34:56"
- assert_eq!(1580646896000, c.value(2));
+ assert!(!c.is_valid(2)); // "2020-2-2T12:34:56"
Review Comment:
Yeah, it is also not correct according to RFC3339, chrono will refuse to
parse it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
