zeroshade commented on code in PR #36489:
URL: https://github.com/apache/arrow/pull/36489#discussion_r1265599658
##########
cpp/src/arrow/buffer.h:
##########
@@ -57,18 +57,25 @@ class ARROW_EXPORT Buffer {
///
/// \note The passed memory must be kept alive through some other means
Buffer(const uint8_t* data, int64_t size)
- : is_mutable_(false), is_cpu_(true), data_(data), size_(size),
capacity_(size) {
+ : is_mutable_(false), is_cpu_(true), data_(data), size_(size),
capacity_(size), device_type_(DeviceType::CPU) {
Review Comment:
Hmm, I think the intent for the `is_cpu_` flag was solely to know whether or
not the data is accessible via CPU rather than caring about the stream ordered
work synchronizations. I intend on expanding the existing classes/objects to
make it easier to synchronize for stream ordered work as a separate
abstraction, so I lean towards leaving it marked as `true` in this case, but
I'm open to changing it.
@pitrou @felipeblazing @Rhonda85 what do you all think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
