alamb commented on PR #7016: URL: https://github.com/apache/arrow-datafusion/pull/7016#issuecomment-1641850236
My benchmark runs confirm what @tustvold suspected that there is no major performance change for this PR ``` -------------------- Benchmark tpch_mem.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ extract-group-values ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 1 │ 570.35ms │ 567.53ms │ no change │ │ QQuery 2 │ 166.07ms │ 162.08ms │ no change │ │ QQuery 3 │ 174.89ms │ 170.65ms │ no change │ │ QQuery 4 │ 115.82ms │ 113.91ms │ no change │ │ QQuery 5 │ 390.04ms │ 388.49ms │ no change │ │ QQuery 6 │ 39.12ms │ 40.99ms │ no change │ │ QQuery 7 │ 956.00ms │ 925.58ms │ no change │ │ QQuery 8 │ 239.53ms │ 249.49ms │ no change │ │ QQuery 9 │ 586.23ms │ 586.65ms │ no change │ │ QQuery 10 │ 331.74ms │ 339.71ms │ no change │ │ QQuery 11 │ 166.03ms │ 155.13ms │ +1.07x faster │ │ QQuery 12 │ 173.20ms │ 174.27ms │ no change │ │ QQuery 13 │ 305.51ms │ 306.92ms │ no change │ │ QQuery 14 │ 48.78ms │ 51.24ms │ 1.05x slower │ │ QQuery 15 │ 52.68ms │ 53.09ms │ no change │ │ QQuery 16 │ 165.92ms │ 172.41ms │ no change │ │ QQuery 17 │ 981.34ms │ 924.09ms │ +1.06x faster │ │ QQuery 18 │ 1644.03ms │ 1696.96ms │ no change │ │ QQuery 19 │ 169.66ms │ 168.50ms │ no change │ │ QQuery 20 │ 334.96ms │ 329.97ms │ no change │ │ QQuery 21 │ 1161.63ms │ 1189.21ms │ no change │ │ QQuery 22 │ 87.75ms │ 90.87ms │ no change │ └──────────────┴───────────┴──────────────────────┴───────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
