alamb commented on code in PR #7025:
URL: https://github.com/apache/arrow-datafusion/pull/7025#discussion_r1267913203
##########
datafusion/core/src/physical_plan/aggregates/row_hash.rs:
##########
@@ -322,16 +322,6 @@ fn create_group_accumulator(
}
}
-/// Extracts a successful Ok(_) or returns Poll::Ready(Some(Err(e))) with
errors
-macro_rules! extract_ok {
Review Comment:
This macro was removed, but I think breaking the main state loop change into
two different functions makes is slightly harder to follow the logic.
Thus I am inclined not to pursue this PR anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
