jackwener commented on code in PR #7069:
URL: https://github.com/apache/arrow-datafusion/pull/7069#discussion_r1272426872
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -482,7 +482,38 @@ impl LogicalPlan {
}
pub fn with_new_inputs(&self, inputs: &[LogicalPlan]) ->
Result<LogicalPlan> {
- from_plan(self, &self.expressions(), inputs)
+ // with_new_inputs use original expression,
+ // so we don't need to recompute Schema.
Review Comment:
to avoid useless recompution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
