alamb commented on code in PR #7101:
URL: https://github.com/apache/arrow-datafusion/pull/7101#discussion_r1275407251
##########
datafusion/core/tests/sqllogictests/test_files/groupby.slt:
##########
@@ -1922,7 +1922,59 @@ SELECT DISTINCT + col1 FROM tab2 AS cor0 GROUP BY
cor0.col1
59
61
-
+# query below should work in multi partition, successfully.
+query II
+SELECT l.col0, LAST_VALUE(r.col1 ORDER BY r.col0) as last_col1
Review Comment:
I ran this test locally without the code change and it asserted 👍
```
❯ SELECT l.col0, LAST_VALUE(r.col1 ORDER BY r.col0) as last_col1
FROM tab0 as l
JOIN tab0 as r
ON l.col0 = r.col0
GROUP BY l.col0, l.col1, l.col2
ORDER BY l.col0;
thread 'thread 'thread
'tokio-runtime-workertokio-runtime-workertokio-runtime-worker' panicked at ''
panicked at '' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `2`thread 'assertion failed: `(left == right)`
left: `1`,
right: `2`', assertion failed: `(left == right)`
left: `1`,
right: `2`',
tokio-runtime-worker/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs',
' panicked at
'/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs:assertion
failed: `(left == right)`
left: `1`,
right:
`2`/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs114',
:::114/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs:1149:9:
114
9note: run with `RUST_BACKTRACE=1` environment variable to display a
backtrace
```
##########
datafusion/core/tests/sqllogictests/test_files/groupby.slt:
##########
@@ -1922,7 +1922,59 @@ SELECT DISTINCT + col1 FROM tab2 AS cor0 GROUP BY
cor0.col1
59
61
-
+# query below should work in multi partition, successfully.
+query II
+SELECT l.col0, LAST_VALUE(r.col1 ORDER BY r.col0) as last_col1
Review Comment:
I ran this test locally without the code change and it asserted 👍
```
❯ SELECT l.col0, LAST_VALUE(r.col1 ORDER BY r.col0) as last_col1
FROM tab0 as l
JOIN tab0 as r
ON l.col0 = r.col0
GROUP BY l.col0, l.col1, l.col2
ORDER BY l.col0;
thread 'thread 'thread
'tokio-runtime-workertokio-runtime-workertokio-runtime-worker' panicked at ''
panicked at '' panicked at 'assertion failed: `(left == right)`
left: `1`,
right: `2`thread 'assertion failed: `(left == right)`
left: `1`,
right: `2`', assertion failed: `(left == right)`
left: `1`,
right: `2`',
tokio-runtime-worker/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs',
' panicked at
'/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs:assertion
failed: `(left == right)`
left: `1`,
right:
`2`/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs114',
:::114/Users/alamb/Software/arrow-datafusion2/datafusion/core/src/physical_plan/aggregates/order/partial.rs:1149:9:
114
9note: run with `RUST_BACKTRACE=1` environment variable to display a
backtrace
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
