tustvold opened a new issue, #7112: URL: https://github.com/apache/arrow-datafusion/issues/7112
### Is your feature request related to a problem or challenge? `AggregateExpr` currently provides both the `ScalarValue` based `Accumulator` and the new `GroupsAccumulator` interface. With an additional `groups_accumulator_supported` to indicate if `GroupsAccumulator` is supported. This is unfortunate as it forces us to keep two accumulator implementations for each expression, which is not only wasteful but introduces the possibility of inconsistency between the two implementations ### Describe the solution you'd like Change `AggregateExpr::create_accumulator` to return `GroupsAccumulator`, and remove `groups_accumulator_supported` and `create_groups_accumulator`. Implementations that currently only have an `Accumulator` based implementation can return a `GroupsAccumulatorAdapter`, which is ultimately what `GroupedHashAggregateStream` will do anyway ### Describe alternatives you've considered _No response_ ### Additional context This blocks https://github.com/apache/arrow-datafusion/issues/6842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
