cyb70289 commented on a change in pull request #9023:
URL: https://github.com/apache/arrow/pull/9023#discussion_r549188645
##########
File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc
##########
@@ -31,61 +31,101 @@
namespace arrow {
namespace compute {
+template <typename ArrowType>
class TestValidityKernels : public ::testing::Test {
protected:
- // XXX Since IsValid and IsNull don't touch any buffers but the null bitmap
- // testing multiple types seems redundant.
- using ArrowType = BooleanType;
-
static std::shared_ptr<DataType> type_singleton() {
return TypeTraits<ArrowType>::type_singleton();
}
};
-TEST_F(TestValidityKernels, ArrayIsValid) {
+typedef TestValidityKernels<BooleanType> TestBooleanValidityKernels;
+typedef TestValidityKernels<FloatType> TestFloatValidityKernels;
+typedef TestValidityKernels<DoubleType> TestDoubleValidityKernels;
+
+TEST_F(TestBooleanValidityKernels, ArrayIsValid) {
CheckScalarUnary("is_valid", type_singleton(), "[]", type_singleton(), "[]");
CheckScalarUnary("is_valid", type_singleton(), "[null]", type_singleton(),
"[false]");
CheckScalarUnary("is_valid", type_singleton(), "[1]", type_singleton(),
"[true]");
CheckScalarUnary("is_valid", type_singleton(), "[null, 1, 0, null]",
type_singleton(),
"[false, true, true, false]");
}
-TEST_F(TestValidityKernels, IsValidIsNullNullType) {
+TEST_F(TestBooleanValidityKernels, IsValidIsNullNullType) {
CheckScalarUnary("is_null", std::make_shared<NullArray>(5),
ArrayFromJSON(boolean(), "[true, true, true, true, true]"));
CheckScalarUnary("is_valid", std::make_shared<NullArray>(5),
ArrayFromJSON(boolean(), "[false, false, false, false,
false]"));
}
-TEST_F(TestValidityKernels, ArrayIsValidBufferPassthruOptimization) {
+TEST_F(TestBooleanValidityKernels, ArrayIsValidBufferPassthruOptimization) {
Datum arg = ArrayFromJSON(boolean(), "[null, 1, 0, null]");
ASSERT_OK_AND_ASSIGN(auto validity, arrow::compute::IsValid(arg));
ASSERT_EQ(validity.array()->buffers[1], arg.array()->buffers[0]);
}
-TEST_F(TestValidityKernels, ScalarIsValid) {
+TEST_F(TestBooleanValidityKernels, ScalarIsValid) {
CheckScalarUnary("is_valid", MakeScalar(19.7), MakeScalar(true));
CheckScalarUnary("is_valid", MakeNullScalar(float64()), MakeScalar(false));
}
-TEST_F(TestValidityKernels, ArrayIsNull) {
+TEST_F(TestBooleanValidityKernels, ArrayIsNull) {
CheckScalarUnary("is_null", type_singleton(), "[]", type_singleton(), "[]");
CheckScalarUnary("is_null", type_singleton(), "[null]", type_singleton(),
"[true]");
CheckScalarUnary("is_null", type_singleton(), "[1]", type_singleton(),
"[false]");
CheckScalarUnary("is_null", type_singleton(), "[null, 1, 0, null]",
type_singleton(),
"[true, false, false, true]");
}
-TEST_F(TestValidityKernels, IsNullSetsZeroNullCount) {
+TEST_F(TestBooleanValidityKernels, IsNullSetsZeroNullCount) {
auto arr = ArrayFromJSON(int32(), "[1, 2, 3, 4]");
std::shared_ptr<ArrayData> result = (*IsNull(arr)).array();
ASSERT_EQ(result->null_count, 0);
}
-TEST_F(TestValidityKernels, ScalarIsNull) {
+TEST_F(TestBooleanValidityKernels, ScalarIsNull) {
CheckScalarUnary("is_null", MakeScalar(19.7), MakeScalar(false));
CheckScalarUnary("is_null", MakeNullScalar(float64()), MakeScalar(true));
}
+TEST_F(TestFloatValidityKernels, FloatArrayIsNan) {
+ CheckScalarUnary("is_nan",
+ ArrayFromJSON(float32(), "[NaN, NaN, NaN, NaN, NaN]"),
+ ArrayFromJSON(boolean(), "[true, true, true, true,
true]"));
+
+ CheckScalarUnary("is_nan",
+ ArrayFromJSON(float32(), "[0.0, 1.0, 2.0, 3.0, 4.0]"),
+ ArrayFromJSON(boolean(), "[false, false, false, false, false]"));
+
+ CheckScalarUnary("is_nan",
+ ArrayFromJSON(float32(), "[0.0, NaN, 2.0, NaN, 4.0]"),
+ ArrayFromJSON(boolean(), "[false, true, false, true, false]"));
Review comment:
also test nulls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
