joemarshall commented on PR #35672: URL: https://github.com/apache/arrow/pull/35672#issuecomment-1662218137
@kou - I've done those tidying up fixes (use of auto, extraneous return statements etc.) Those two test cases that you flagged, I checked through them again, and I think I was wrong - they probably don't really make sense in single-threaded mode as they're testing essentially multithreaded behaviour. I've just skipped those tests in single threaded mode. The description at the top of the PR is up to date now (and has a brief changelog of what changed from initial PR), so hopefully good to go. thanks Joe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
