alamb commented on code in PR #7130:
URL: https://github.com/apache/arrow-datafusion/pull/7130#discussion_r1283620246
##########
datafusion/core/tests/memory_limit.rs:
##########
@@ -205,9 +307,17 @@ struct TestCase {
memory_limit: usize,
config: SessionConfig,
scenario: Scenario,
+ /// How should the disk manager (that allows spilling) be
+ /// configured? Defaults to `Disabled`
+ disk_manager_config: DiskManagerConfig,
+ /// Expected explain plan, if non emptry
+ expected_plan: Vec<String>,
+ /// Is the plan expected to pass? Defaults to false
+ expected_success: bool,
}
impl TestCase {
+ // TODO remove expected errors and memory limits and query from constructor
Review Comment:
https://github.com/apache/arrow-datafusion/pull/7190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
