zeroshade commented on code in PR #961: URL: https://github.com/apache/arrow-adbc/pull/961#discussion_r1283747444
########## adbc.h: ########## @@ -438,45 +425,7 @@ struct AdbcErrorDetail AdbcErrorGetDetail(struct AdbcError* error, int index); /// The type is char*. /// /// \since ADBC API revision 1.1.0 -/// \addtogroup adbc-1.1.0 #define ADBC_OPTION_PASSWORD "password" -/// \brief Canonical option name for error details. -/// -/// Should be used as the expected option name to retrieve error -/// details from the driver. This allows drivers to return custom, -/// structured error information (for example, JSON or Protocol -/// Buffers) that can be optionally parsed by clients, beyond the -/// standard AdbcError fields, without having to encode it in the -/// error message. The encoding of the data is driver-defined. -/// Drivers may provide multiple error details. -/// Review Comment: Ah sorry. A bit discombobulated, this all makes sense now haha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
